chore: [CONTRIBUTING.md] add Hermit to instructions#6518
Conversation
blackgirlbytes
left a comment
There was a problem hiding this comment.
thanks but im not too sure we need this PR. I think it changes a lot of things we were trying to be intentional about. I can help you find some issues where we truly need assistance!
CONTRIBUTING.md
Outdated
| ## Quick Responsible AI Tips | ||
|
|
||
| If you use Goose, Copilot, Claude, or other AI tools to help with your PRs: | ||
| If using Goose, or other AI tools to help with contributions: |
There was a problem hiding this comment.
hmm we're okay with other AI tools using AI tools besides goose...
|
There are some beneficial additions you added about hermit activation, the short hand -s for signoff, and you fixed a typo where it said "settups" and "submiting" . Thank you. Let's keep those. But if possible can you remove the other changes..our voice and branding for new contributors to goose is intentionally warm and friendly 😄 |
c1de8d4 to
4ba0ca3
Compare
|
@blackgirlbytes Should be ready now |
CONTRIBUTING.md
Outdated
| ### Before Submitting a Pull Request | ||
|
|
||
| Before you submit a pull request, please ensure your fork is synchronized as described above. This check ensures your changes are compatible with the latest in the main repository and streamlines the review process. | ||
| Before submitting a pull request, please ensure your fork is synchronized as described above. This check ensures your changes are compatible with the latest in the main repository and streamlines the review process. |
There was a problem hiding this comment.
I would keep the language as was written. "you submit" is meant to feel more personal!
CONTRIBUTING.md
Outdated
|
|
||
| First let's compile goose and try it out | ||
| First let's activate Hermit. | ||
| Goose requires Hermit for managing dependencies. |
There was a problem hiding this comment.
how about a minor change that combines what was there to bring it together?
- First let's compile goose and try it out
- Since goose requires Hermit for managing dependencies, let's activate hermit.
taniandjerry
left a comment
There was a problem hiding this comment.
Left minor feedback to keep language carefully written from before, while also accepting the Hermit contribution to this guide
4ba0ca3 to
5783416
Compare
|
@taniandjerry |
|
oh please fix the merge conflict and i can merge it! |
|
@Yorisoft checking if you can fix the merge conflicts and we will merge asap thanks! |
9c3e466 to
f303b2b
Compare
Signed-off-by: Yelsin Sepulveda <yelsinsepulveda@gmail.com>
Signed-off-by: Yelsin Sepulveda <yelsinsepulveda@gmail.com>
f303b2b to
bfa3985
Compare
…upport * origin/main: (79 commits) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718) fix: dispatch ADD_ACTIVE_SESSION event before navigating from "View All" (#6679) Speed up Databricks provider init by removing fetch of supported models (#6616) fix: correct typos in documentation and Justfile (#6686) docs: frameDomains and baseUriDomains for mcp apps (#6684) docs: add Remotion video creation tutorial (#6675) docs: export recipe and copy yaml (#6680) ... # Conflicts: # ui/desktop/src/hooks/useChatStream.ts
…ovider * 'main' of github.com:block/goose: fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700)
* 'main' of github.com:block/goose: Create default gooseignore file when missing (#6498) fix slash and @ keyboard navigation popover background color (#6550) fix[format/openai]: return error on empty msg. (#6511) Fix: ElevenLabs API Key Not Persisting (#6557) Logging uplift for model training purposes (command injection model) [Small change] (#6330) fix(goose): only send agent-session-id when a session exists (#6657) BERT-based command injection detection in tool calls (#6599) chore: [CONTRIBUTING.md] add Hermit to instructions (#6518) fix: update Gemini context limits (#6536) Document r slash command (#6724) Upgrade GitHub Actions to latest versions (#6700) fix: Manual compaction does not update context window. (#6682) Removed the Acceptable Usage Policy (#6204) Document spellcheck toggle (#6721) fix: docs workflow cleanup and prevent cancellations (#6713) Docs: file bug directly (#6718)
Summary
Type of Change
AI Assistance
Testing
Related Issues
Relates to: fixes #6517
Screenshots/Demos (for UX changes)
Before:
https://github.com/block/goose/blob/main/CONTRIBUTING.md
After:
https://gist.github.com/Yorisoft/33b425458da52d6e2b1a341d9e9c5091